Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React v16 (for tests) #340

Merged
merged 3 commits into from
Oct 18, 2017
Merged

Upgrade to React v16 (for tests) #340

merged 3 commits into from
Oct 18, 2017

Conversation

fahad19
Copy link
Member

@fahad19 fahad19 commented Oct 14, 2017

This PR upgrades all dependencies to be compatible with React v16.

While latest release of FrintJS on npm is already compatible with React 16, the tests in the repo are still written targeting v15.

Before merge

After merge

  • Update React version in examples

What's done

  • All relevant dependencies upgraded
  • Tests: requestAnimationFrame is set globally for React v16
  • Tests: Enzyme adapter for React v16 is set via frint-test-utils/register hook

What's failing

Tests from frint-router-react are failing. You can reproduce them by running:

$ git checkout react16

$ npm install
$ npm run bootstrap

$ (cd ./packages/frint-router-react && npm test)

@fahad19 fahad19 self-assigned this Oct 14, 2017
@fahad19 fahad19 requested a review from a team October 14, 2017 19:33
@fahad19
Copy link
Member Author

fahad19 commented Oct 18, 2017

Fix is in progress in #343.

ascariandrea and others added 2 commits October 18, 2017 13:01
* Fixed frint-router-react tests for React 16 compatibility

* Fixe tests for empty innerHTML when no root app is available.
@fahad19 fahad19 changed the title [HELP WANTED] Upgrade to React v16 (for tests) Upgrade to React v16 (for tests) Oct 18, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 97.439% when pulling a76b217 on react16 into 8a00fdd on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 97.439% when pulling a76b217 on react16 into 8a00fdd on master.

@fahad19 fahad19 merged commit 974768e into master Oct 18, 2017
@fahad19 fahad19 deleted the react16 branch October 18, 2017 11:11
@fahad19 fahad19 mentioned this pull request Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants