-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frint-di: move it into monorepo #403
Conversation
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
==========================================
+ Coverage 97.39% 97.45% +0.05%
==========================================
Files 101 105 +4
Lines 3992 4120 +128
==========================================
+ Hits 3888 4015 +127
- Misses 104 105 +1
Continue to review full report at Codecov.
|
The |
Thanks for the gist, @markvincze! I am probably doing something wrong myself, but updating the typings is now failing the build for some reason. I will investigate further from office tomorrow. |
It was failing in I removed the Cannot confirm about idiomatic TypeScript myself, but there is this Issue here that may help understand more: microsoft/TypeScript-Handbook#121 |
What's done
travix-di
(which is a fork ofdiyai
), into the monorepoWhy
frint
package itself as a dependency and extremely importantBefore merge