Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix a bug when version is missing in configuration but passed as argument #190

Merged
merged 1 commit into from
Sep 23, 2020
Merged

🐛 Fix a bug when version is missing in configuration but passed as argument #190

merged 1 commit into from
Sep 23, 2020

Conversation

frinyvonnick
Copy link
Owner

Fix #181

@frinyvonnick
Copy link
Owner Author

frinyvonnick commented Jul 30, 2020 •
edited

Hi @mathieutu,

This change should fix your bug 🎉 Could you test it and confirm the issue is fixed?

Sorry for taking so long time to work on it...

@frinyvonnick frinyvonnick force-pushed the fix-missing-version-in-package.json branch from 1c252cf to 787857b Compare July 30, 2020 11:09
@frinyvonnick frinyvonnick changed the base branch from master to functional-errors July 30, 2020 11:09
@frinyvonnick frinyvonnick force-pushed the fix-missing-version-in-package.json branch from 787857b to 7ac92e6 Compare July 30, 2020 11:10
@mathieutu
Copy link
Contributor

Thanks!
However I'm sorry but I'm currently in holidays, so I'll not be available for testing this until September...

@frinyvonnick
Copy link
Owner Author

No problem, have fun during holidays 🌴

@frinyvonnick
Copy link
Owner Author

Hi @mathieutu 👋

Hope you spent nice holidays 🏖️ Do you have some time to give a test to this PR?

@mathieutu
Copy link
Contributor

Hi!
Yeah I'm back.

Do you have tagged a version I can test easily?
I'll test it with any of my php package, so if you want to, you can try with https://github.com/mathieutu/php-project-launcher: yarn changelog 1.0.0

@frinyvonnick
Copy link
Owner Author

Ok I test it 👍

@frinyvonnick
Copy link
Owner Author

It looks good to me @mathieutu 👌

image

@mathieutu
Copy link
Contributor

Perfect, thank you!

@mathieutu mathieutu mentioned this pull request Sep 23, 2020
Closed
Base automatically changed from functional-errors to master September 23, 2020 07:29
@frinyvonnick frinyvonnick merged commit 24332f0 into master Sep 23, 2020
@frinyvonnick frinyvonnick deleted the fix-missing-version-in-package.json branch September 23, 2020 07:30
frinyvonnick added a commit that referenced this pull request Sep 25, 2020
@frinyvonnick
🐛 Fix a bug occuring when version is missing in configuration but pas…
20cf369 
…sed as argument (#190)
@mathieutu
Copy link
Contributor

mathieutu commented Dec 7, 2020 •
edited

Hi @frinyvonnick, I still have the problem on 2.1.0. Is it normal? Did you tag a release?

Thanks.

EDIT: ok, it's working on canary, could we tag a release?

@frinyvonnick
Copy link
Owner Author

Sure @mathieutu 🙂

I'll do it as soon as possible !

@mathieutu
Copy link
Contributor

thanks!

@frinyvonnick
Copy link
Owner Author

I just published it in v2.2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Version passed to cli ignored
2 participants
@frinyvonnick @mathieutu