Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update sample code in README #204

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

Tiffceet
Copy link
Contributor

@Tiffceet Tiffceet commented Jun 21, 2023

The sample code given in the readme may not work if the encoded base64 includes = which handlebars.js gladly escapes to =

Updated sample code in readme to insert base64 content unescaped https://handlebarsjs.com/guide/#html-escaping

Here is a sample image to test on:
beidou

- fix: the given font example wasnt working
- fix: image converted to base64 should be printed into template unescaped
@frinyvonnick
Copy link
Owner

Hello @Tiffceet 👋

Thank you for your contribution 🙏

@frinyvonnick frinyvonnick merged commit 5ac5bc8 into frinyvonnick:master Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants