Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema_version supports defination via version module #48

Closed
wants to merge 5 commits into from

Conversation

p-alik
Copy link

@p-alik p-alik commented Dec 1, 2016

I trapped into exception:

Attribute (schema_version) does not pass the type constraint because: Schema version (currently 'v0.11') must be a string at reader DBIx::Class::DeploymentHandler::Dad::schema_version (defined at ../DBIx-Class-DeploymentHandler/lib/DBIx/Class/DeploymentHandler/Dad.pm line 30

because I used version modul for schema version definition. Therefore I slightly modified your implementation and I hope it could be useful for the other perl geeks.

@coveralls
Copy link

coveralls commented Dec 1, 2016

Coverage Status

Coverage increased (+0.3%) to 92.561% when pulling c206776 on p-alik:master into c9528ca on frioux:master.

@p-alik
Copy link
Author

p-alik commented Dec 7, 2016

It looks like my PR doesn't meet your approach By default DBIx::Class::DeploymentHandler only uses integers for versions

however if you think it could be useful I'll spend more time because in this state it doesn't work

@p-alik p-alik closed this Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants