string logging code sketch #12
Conversation
|
Please also add tests
…--
sent from a rotary phone, pardon my brevity
On Aug 17, 2017 11:04 AM, "Coveralls" ***@***.***> wrote:
[image: Coverage Status] <https://coveralls.io/builds/12882447>
Coverage decreased (-6.2%) to 89.781% when pulling *162b0f7
<162b0f7>
on wchristian:bare_string_logging* into *bf69be8
<bf69be8>
on frioux:master*.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAf49iZJK1Wv8_go06h0ElOwcQVTcF7ks5sZICygaJpZM4O6m6e>
.
|
|
Also seems like it'll do odd things if passed a false string?
…--
sent from a rotary phone, pardon my brevity
On Aug 17, 2017 12:52 PM, "fREW Schmidt" ***@***.***> wrote:
Please also add tests
--
sent from a rotary phone, pardon my brevity
On Aug 17, 2017 11:04 AM, "Coveralls" ***@***.***> wrote:
> [image: Coverage Status] <https://coveralls.io/builds/12882447>
>
> Coverage decreased (-6.2%) to 89.781% when pulling *162b0f7
> <162b0f7>
> on wchristian:bare_string_logging* into *bf69be8
> <bf69be8>
> on frioux:master*.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#12 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAAf49iZJK1Wv8_go06h0ElOwcQVTcF7ks5sZICygaJpZM4O6m6e>
> .
>
|
wchristian
force-pushed
the
bare_string_logging
branch
from
162b0f7
to
139c586
Compare
|
Added tests, including a failing test for pre-existing code, and fixed the handling of '' or '0'. Docs coming next. |
|
Alright, docs and code can be considered ready if you're ok with them. The question is what should happen with slog and slogS when given arguments. Right now they ignore them. An alternative i can think of is having them append them to the string with Which of those do you prefer? |
|
I think I prefer how it is now, but only because it's slightly simpler. |
|
Alright, then you can go ahead and pull, i think. :) |
|
BTW your DlogS test is wrong; the S stands for scalar, and an empty list is not a scalar. I'm probably going to just drop that test. Also the code fails the tidy test but I'll just take care of that and ensure that in the future travis runs that automatically. |
|
Sure, thanks for the double-check. I must admit the tests had me getting into the woods a little. :) As for tidy: Sorry, i'm not used to other people using it and didn't notice it when it scrolled past. |
|
Merged, about to release. |
This is a sketch for #7