don't skip exports that exist in parent class #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the fully qualified sub we are trying to export rather than using can, otherwise we skip exporting subs that exist in the parent class.
|
I suspect this reduces both memory and startup time. Have you looked into
either of those? What motivated this patch?
…--
Sent from a rotary phone rented from Ma Bell
On Nov 21, 2017 6:32 AM, "Graham Knop" ***@***.***> wrote:
Check the fully qualified sub we are trying to export rather than using
can, otherwise we skip exporting subs that exist in the parent class.
------------------------------
You can view, comment on, or merge this pull request online at:
#13
Commit Summary
- don't skip exports that exist in parent class
File Changes
- *M* lib/Log/Contextual.pm
<https://github.com/frioux/Log-Contextual/pull/13/files#diff-0> (4)
- *A* t/inherit.t
<https://github.com/frioux/Log-Contextual/pull/13/files#diff-1> (33)
Patch Links:
- https://github.com/frioux/Log-Contextual/pull/13.patch
- https://github.com/frioux/Log-Contextual/pull/13.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#13>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAf4_6ppcnuMCc2PyBx5VVccaGq56Ctks5s4t7IgaJpZM4Ql7gs>
.
|
|
The test demonstrates the issue. If a class using Log::Contextual inherits from another class using Log::Contextual, the child class won't get the exports, so any attempt to use the log_* subs will fail. |
|
Ah sorry my bad
…--
Sent from a rotary phone rented from Ma Bell
On Nov 21, 2017 7:20 AM, "Coveralls" ***@***.***> wrote:
[image: Coverage Status] <https://coveralls.io/builds/14307150>
Coverage decreased (-0.4%) to 95.582% when pulling *0be7ad8
<0be7ad8>
on haarg:fix-child-export* into *bf69be8
<bf69be8>
on frioux:master*.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAf44UokSfU6WsNVtJkoKLjXEUrjwOHks5s4uoigaJpZM4Ql7gs>
.
|
|
Merged, releasing shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the fully qualified sub we are trying to export rather than using
can, otherwise we skip exporting subs that exist in the parent class.