Throw an exception if the program exited non-zero

Changes

@@ -1,6 +1,7 @@
 Revision history for {{$dist->name}}
 
 {{$NEXT}}
+  - Throw an exception if the program exited non-zero
 
 0.001001  2014-06-02 17:15:33-05:00 America/Chicago
   - Hopefully fix tests on MSWin32

cpanfile

@@ -4,6 +4,7 @@ requires 'Moose';
 requires 'Pod::Weaver::Role::Dialect';
 requires 'Pod::Elemental::Transformer';
 requires 'Capture::Tiny';
+requires 'IPC::System::Simple';
 requires 'Moose::Autobox';
 requires 'namespace::clean';
 

lib/Pod/Weaver/Plugin/Exec.pm

@@ -15,7 +15,8 @@ package
    use Moose;
    with 'Pod::Elemental::Transformer';
 
-   use Capture::Tiny 'capture_stdout';
+   use Capture::Tiny 'capture';
+   use IPC::System::Simple 'system';
    use Moose::Autobox;
    use namespace::clean;
 
@@ -35,7 +36,17 @@ package
            and $para->children->[0]->isa('Pod::Elemental::Element::Pod5::Data');
 
          chomp(my $command = $para->children->[0]->content);
-         my $out = capture_stdout { system($command) };
+
+         local $@;
+         my ($out, $err, $ok) = capture {
+            eval { system $command; 1 };
+         };
+
+         chomp $out;
+         chomp $err;
+         die "Command '$command' failed\nSTDOUT: $out\nSTDERR: $err\n"
+            unless $ok;
+
          $out = join "\n", map " $_", split /\n/, $out;
 
          my $new_doc =

t/fail-on-error.t

@@ -0,0 +1,39 @@
+use strict;
+use warnings;
+
+use Test::More;
+use Test::Fatal;
+
+use Pod::Elemental;
+use Pod::Elemental::Transformer::Pod5;
+use Pod::Weaver::Plugin::Exec;
+
+my $str = do { local $/; <DATA> };
+
+my $doc = Pod::Elemental->read_string($str);
+
+Pod::Elemental::Transformer::Pod5->new->transform_node($doc);
+
+my $e = exception {
+   Pod::Elemental::Transformer::Exec->new->transform_node($doc)
+};
+
+ok $e, 'correctly got exception';
+like $e, qr/STDOUT: station!/, 'STDOUT included';
+like $e, qr/STDERR: got an error :\(/, 'STDERR included';
+like $e, qr/Command 'perl -E.*' failed/, 'Command included';
+
+note "Exception: $e";
+
+
+done_testing;
+
+__DATA__
+=pod
+
+=head1 Welcome to Pod!
+
+=for exec
+perl -E"say 'station!'; die 'got an error :('"
+
+Right??

t/simple.t

@@ -28,6 +28,8 @@ Right??
 =cut
 POD
 
+note('POD: ' . $doc->as_pod_string);
+
 done_testing;
 
 __DATA__