Better patch for smartmatch deprecation. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch silences the 'deprecated::smartmatch' warning on perl 5.38.0, and if perl version is 5.42.0 or later, smartmatch is not used at all. This should more gracefully handle the smartmatch deprecation as user code relying on junction matching that uses smartmatch will still get a depreaction warning starting in 5.38.0, but older perls will not be impacted. On 5.38.0 or later, no deprecation warning will be issued unless actual calling code relies on smartmatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch silences the 'deprecated::smartmatch' warning on perl 5.38.0, and if perl version is 5.42.0 or later, smartmatch is not used at all. This should more gracefully handle the smartmatch deprecation as user code relying on junction matching that uses smartmatch will still get a depreaction warning starting in 5.38.0, but older perls will not be impacted. On 5.38.0 or later, no deprecation warning will be issued unless actual calling code relies on smartmatch.
TL;DR: this patch fixes the deprecated warning on 5.38.0 for code that doesn't actually rely on smartmatch, and when smartmatch is removed (scheduled for 5.42.0 according to
perldiag), then smartmatch support will automatically be removed from this module.