Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geber export svg stroke-width bug #3262

Closed
ThomDietrich opened this issue Jul 23, 2016 · 5 comments
Closed

Geber export svg stroke-width bug #3262

ThomDietrich opened this issue Jul 23, 2016 · 5 comments

Comments

@ThomDietrich
Copy link

ThomDietrich commented Jul 23, 2016

While defining my own part I stumbled over a nasty bug in the way svgs are converted which only effects the gerber export function and therefor may stay undiscovered before manufacture.

My part got translated to a nice set of lines on silkscreen in pdf or svg export (first image), so everything seemed fine. However the gerber export produced thick unwanted lines (second image).

The following change in pcb.svg was needed to fix that problem for my part: https://github.com/fritzing/fritzing-parts/pull/73/files

@ThomDietrich
Copy link
Author

Unsure if this is related to and will be solved by #3203
@Kazade would you be able to test the part?

@el-j
Copy link
Contributor

el-j commented Mar 31, 2017

thanks for point this out.
it is known that every connector needs his own stroke-width element to export properly.
the stroke-width element on cooper-group on any other group is not allowed.

this is more a parts issue than a fritzing app-issue.
the fritzing-parts repository needs automatic checks for such issues. it is planed to do these checks + corrections for every contributed part in future.

close this because of parts-issue

@el-j el-j closed this as completed Mar 31, 2017
@ThomDietrich
Copy link
Author

ThomDietrich commented Mar 31, 2017

Hey @el-j, closing the ticket in favor of an referencing parts issue would have been fine by me. Without the referencing parts issue you lost this ticket, are you sure that's how you want to deal with this?

The described problem is a nasty bug which should not be lost in closed tickets.

@el-j
Copy link
Contributor

el-j commented Mar 31, 2017

ok, you are right.
so maybe we can have the issue like that:
fritzing/fritzing-parts#94

closed again ;)

@ThomDietrich
Copy link
Author

Thanks ;) Keep up the great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants