-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New gerber export #3203
Merged
Merged
New gerber export #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure it worked, had a work around some Qt SVG raster bugs.
- use clipper for all boolean operations - avoid ragged edges on polygons
-remove reference to deleted file.
-cleanup after svg2gerber class removal
- remove non-standard instance variable initialization.
- remove more non-standard instance variable initialization. - back-port some Qt 5.3 features.
- add forgotten "%" after header in excellon drill file
- improve compatibility of generated gerber.
- fix Qt version detection
- try to fix Excellon export by padding coordinates with zeros up to 6 figures
- clip layers according to the stack logic in gerber export
- clip drill file with the PCB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase (with a few fixes) of #3083 on latest master. There are still some issues with the Gerber export, but one notable thing is this fixes #3196.
Oddly I'm having a problem both in this version, and current master where there is something wrong with the copper layers and sites like OSHPark just ignore them (helpfully without any warnings) - I can't explain this at the moment.
I intend to try and hammer this into shape because #3196 is causing me pain but I thought I'd open this PR now so others can test and maybe help me figure out what's still broken.