use port number passed into make and fix uploads #2
Conversation
tcp_bridge/tcp_bridge.c
Outdated
| } No newline at end of file | ||
| } |
There was a problem hiding this comment.
The compiler on my Mac complains if there isn't a line break here:
tcp_bridge.c:132:2: error: no newline at end of file [-Werror,-Wnewline-eof]
jadatkins
changed the title
|
Thanks for the PR, I'll accept it. Yes, somehow I've completely missed the option for setting the port in LightBurn, so I thought it was hardcoded to 23 (their user interface for setting IP and port in completely different places is a bit confusing, TBH). That's the only reason I wrote that tcp_bridge program at all. Just after pushing the tcp_bridge feature to github, I noticed the port setting in LB, so I'm currently in the process of refactoring and testing the python code to use sockets directly, without the bridge. Honestly I'm unsure whether to keep the tcp_bridge at all, because there is no real reason to bind to ports below 1024 at all. |
|
Ah, then you've also found the setting to reverse the Z axis in LightBurn, I suppose? It's in the same dialog at the top-right. In your code comments you state that the correct Z value for a material of thickness 0 is 17, but you also say that empirically you found it to be closer to 19. What made you think it was 17? When I perform a "score" using xTool Creative Space and set the material as 3mm basswood plywood, in Wireshark I can see that it is setting a Z height of 17. This makes me think that the value for a material of thickness 0 would be 20. Is it possible you got mixed up somehow? |
|
Yes, I found the reverse Z switch, but that does not really help, does it? I've found no option in LB to set a Z offset, so we need to touch all Z coordinates in the G-code anyways, so using reverse Z makes no difference (except swapping a minus for a plus in the code). I thought, that the G-code from the XCS software was cutting at Z=17 for a material thickness of zero, that's where I got this value from. Also, the maximum material thickness I can set in XCS is 16. However, i may have made a mistake somewhere (seems likely, since the focus was that far off for me). |
|
Here's a capture I made scoring a short line on 3mm plywood. The Z value of 17 is set at the start when all the other defaults are set, and then it doesn't get set again. |
|
I've created an issue for this, let's continue the discussion there. (is there no way to lock this conversation?) |
macOS does not have the
setcapcommand so it seems it will be simpler on a Mac to use a port number like 8023 and change it in LightBurn device settings. But you're not actually using the port number passed intomake– you're hardcoding it in the C source file.