This repository has been archived by the owner on Feb 19, 2020. It is now read-only.
Use ssl.get_protocol_name() to find out which TLS version is in use
#407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allows the latest TLS versions to be used as well as any future versions).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to use TLSv1.2 for a project I am working on, it appears that it is possible to set the
self.ssl_versionattribute tossl.PROTOCOL_TLSv1_2but then the debug log throws a KeyError exception. This can be fixed one of 2 ways:ssl_versions(4and5forTLSv1.1andTLSv1.2respectively).ssl.get_protocol_name()method to let the Python SSL library do it for us.I chose the latter because when new versions get added to the library they would most probably be added to the
ssl.get_protocol_name()method, which means next time I won't have to do a pull request. :)Note: The format of the log output will be slightly different because the string format is different from the hardcoded dictionary. If someone is using this log entry in a script, it may break. However I think it's fair to assume that we can safely change this.