Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Add compatibility with Nova 2.1.0 #30

Closed
wants to merge 1 commit into from

Conversation

bmichotte
Copy link

Nova 2.1.0 added showOnIndex($callback) on Laravel\Nova\Fields\FieldElement

This PR add the compatibility with it to avoid the following error

Declaration of Froala\NovaFroalaField\Froala::showOnIndex() should be compatible with Laravel\Nova\Fields\FieldElement::showOnIndex($callback = true)

@niekdemelker
Copy link

niekdemelker commented Aug 21, 2019

Why not remove the function here? you don't really need the overwrite and its more future proof. Don't overwrite what doesn't need overwriting. Overwriting is what caused this issue in the first place.

@bmichotte
Copy link
Author

@niekdemelker, I’m totally agree with you, but as the original code was forcing showOnIndex to true, I kept the same behavior.

But we are agree that this method should be removed

@slavarazum
Copy link
Collaborator

Method removed - #32

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants