Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Updated for Laravel 6.0 #35

Closed
wants to merge 3 commits into from
Closed

Updated for Laravel 6.0 #35

wants to merge 3 commits into from

Conversation

jdanino
Copy link

@jdanino jdanino commented Sep 4, 2019

Updated for Laravel 6.0

@slavarazum
Copy link
Collaborator

Hi, thanks for this PR.
Why minimum php version should be upped to 7.2?

@niekdemelker
Copy link

niekdemelker commented Sep 4, 2019

@slavarazum minimum version shouldn't be upped, laravel 5.8 needs a minimum of 7.1.3 and so does this package, so only adding laravel 6.0 should be enough.

@jdanino
Copy link
Author

jdanino commented Sep 5, 2019

Thanks, you are right. I changed it to 7.1.3

@niekdemelker
Copy link

@slavarazum could you please merge this? That would be great.

@slavarazum
Copy link
Collaborator

slavarazum commented Sep 6, 2019

Added comatibility in 3.2.0 version. Dropped laravel/framework dependency from compose.json, because it unnecessary with laravel/nova dependency.

Let me know if you will have any issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants