Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Hotfix for path/url selection when running local or remote server #42

Closed
wants to merge 1 commit into from

Conversation

sinnbeck
Copy link

Fix for issue listed here
#41

Tested both using phpunit and in the browser

@slavarazum
Copy link
Collaborator

Have you tested it on cloud drives like s3?
It should include some testcases.

@sinnbeck
Copy link
Author

sinnbeck commented Nov 1, 2019

I was going to look into your current test cases as I would assume this is already tested using s3, but I didn't find any? I see a test for the public disk and that test is still green.
Also its only the local part that has changed. Anything cloudbased is unaltered :)

@slavarazum
Copy link
Collaborator

Thanks for your PR. But if you want to change some source code, you should provide a full maintenance for it with working guarantee in all edge cases (with appropriate test cases).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants