Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 3.2.6-1: table.edit popup no longer shows when several cells are selected #4199

Closed
earshinov opened this issue Mar 22, 2021 · 7 comments

Comments

@earshinov
Copy link

Demo

Please see CodeSandbox:

Repro steps

  1. Select several cells:

![image](https://user-images.githubusercontent.com/52021/112049098-3a875100-8b
60-11eb-8fa2-5314a55cacf2.png)

Expected behavior

  • Table properties popup should appear:

image

Actual behavior

  • The popup appears in v3.2.6, but not in v3.2.6-1

Version information

Browser: Google Chrome 89.0.4389.90
Froala: regression in 3.2.6-1

froala diff

@kaniansky
Copy link

Duplicate of #4155, #4191, #4198 and #4197

@earshinov
Copy link
Author

@kaniansky , I don't think it's a duplicate. In the case I describe in this issue there is no tag around the table, and no Uncaught TypeError: Cannot read property 'length' of undefined exception.

@earshinov
Copy link
Author

earshinov commented Mar 27, 2021

Also, this only happens in v3.2.6-1, which rules out #4155 at least.

@beatrixmorar
Copy link

This seems to be a duplicate of #4206
Is there some kind of workaround to make this work with v3.2.6-1? Or is there any information from Froala, when should we expect a fix for this?

@earshinov
Copy link
Author

@beatrixmorar , here is what Froala Support replied (we have a paid license):

I've submitted the bug to the dev-team but a timeframe for a fix for this issue is not yet been established.

We chose to roll back to 3.2.6.

@AkshayCM
Copy link

Thanks for your feedback.
This issue is not reproducible or have been found to be fixed on the latest Froala release v4.0.8.
Can you please upgrade and check?

@earshinov
Copy link
Author

I can confirm that this issue is fixed in 4.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants