Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit in Froala as well as opening Code View, because image caption has whitespace between img and span.fr-inner #4682

Open
tor-inge opened this issue Sep 15, 2023 · 1 comment

Comments

@tor-inge
Copy link

tor-inge commented Sep 15, 2023

Expected behavior.

Should open code view. Be able to start editing.

Actual behavior.

Uncaught TypeError: o.setAttribute is not a function.
This occurs because o is #text not actually an element. Should change to nextElementSibling instead of nextSibling.

Steps to reproduce the problem.

Try to start editing in the froala editor and try to open code view. Test out here: https://jsfiddle.net/tq9h5Lwu/1/

Editor version.

Version 4.1.2

OS.

Windows 11 OS build 22000.2295

Browser.

Google Chrome Version 116.0.5845.188 (Official Build) (64-bit)

Recording.

Not needed. Try to open Code View or start editing in the Froala Editor jsFiddle

tor-inge added a commit to tor-inge/wysiwyg-editor that referenced this issue Sep 15, 2023
Changed three "nextSibling" to "nextElementSibling". Code View and editing works again.
@ChristmasWoe
Copy link

ChristmasWoe commented Oct 2, 2023

Have the same problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants