Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when loading app settings (Cannot read properties of undefined (reading 'CONTROLLED_ON')) #283

Closed
frodeheg opened this issue Nov 18, 2023 · 0 comments
Closed

Error when loading app settings (Cannot read properties of undefined (reading 'CONTROLLED_ON')) #283

frodeheg opened this issue Nov 18, 2023 · 0 comments
Labels
bug Something isn't working
Milestone
Version 0.22.0 Ge...

Comments

@frodeheg
Copy link
Owner

An user reported a case where this message appear while loading the app:
"Error: Cannot read properties of undefined (reading 'CONTROLLED_ON')"
image

I believe the problem is caused by this definition being in the external file 'constants.js', then trying to run the javascript code before the external file has completed loading causes the error to appear.

Tracking of external file load-status has already been added to the piggy_charger branch. Thus the fix need to be part of that branch.
@frodeheg frodeheg added the bug Something isn't working label Nov 18, 2023
frodeheg added a commit that referenced this issue Nov 18, 2023
@frodeheg
Ticket #283, #173, #163: Made sure variables defined in constants.js …
742e82d 
…are not used before the file has loaded.

Ticket #283: The actual bug report.
Ticket #173: The problem was introduced with this ticket
Ticket #163: The fix must be part of the car_charger branch as there is no tracking of loading state of external files on the main branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Version 0.22.0 Generic car charger su...
Development

No branches or pull requests
1 participant
@frodeheg