Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add description tag from ifAlias #3

Closed
wants to merge 1 commit into from

Conversation

pdion891
Copy link

@pdion891 pdion891 commented Apr 2, 2016

Added description tag from ifAlias for network interfaces.

This might be an ugly piece of code to implement the tag. If you have a cleaner code, cancel this PR and enable the tag if possible.

tested with OpenTSDB 2.2

Regards,

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 77.82% when pulling 7405d7c on pdion891:multiprocess into 98ad149 on frogmaster:multiprocess.

@pdion891 pdion891 closed this Apr 2, 2016
@frogmaster
Copy link
Owner

I think it would be better to use separate resolver class for this. For example subclass IfName class IfAlias(IfName) and add it to setup.py "ifname_ifalias=opentsdb.snmp.resolvers.ifname:IfAlias", or something along those lines...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants