Improve support for JSON parameters #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using api.parameters decorator, the locations parameter is now taken into account to generate the documentation ("@api.parameters(parameters.MyParameters(many=False), locations=('json',))".
| @@ -70,6 +70,8 @@ def decorator(func): | |||
| _locations = ('json', ) | |||
| else: | |||
| _locations = locations | |||
| if locations is not None: | |||
There was a problem hiding this comment.
I think we need to check _locations (with underscore) here.
There was a problem hiding this comment.
My intent was to set parameters context only if locations was user-specified.
|
I'm sorry for the delay, I have been out of town. Once we resolve the above comment, I am happy to merge this PR. |
|
I have cherry-picked your PR and merged it into master with the according fixes. Thank you! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using api.parameters decorator, the locations parameter is now taken into account to generate the documentation ("@api.parameters(parameters.MyParameters(many=False), locations=('json',))".