Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve 'no transaction is begun' error when invoking tasks #70

Merged
merged 2 commits into from
Oct 6, 2017
Merged

Resolve 'no transaction is begun' error when invoking tasks #70

merged 2 commits into from
Oct 6, 2017

Conversation

askz
Copy link
Contributor

@askz askz commented Oct 6, 2017

No description provided.

@coveralls
Copy link

coveralls commented Oct 6, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 94.105% when pulling ab60871 on askz:patch-1 into 590d919 on frol:master.

@askz askz mentioned this pull request Oct 6, 2017
Open
@frol
Copy link
Owner

frol commented Oct 6, 2017

Good catch! Let's use with db.session.begin(): context manager instead of explicit begin+commit. Will you be so kind to update your PR?

@askz
Copy link
Contributor Author

askz commented Oct 6, 2017 •
edited
Loading

Of course !

Let me know if there's anything.

(I tested it locally ofc)

@coveralls
Copy link

coveralls commented Oct 6, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 94.105% when pulling f062c21 on askz:patch-1 into 590d919 on frol:master.

@frol frol merged commit c418f6a into frol:master Oct 6, 2017
@frol
Copy link
Owner

frol commented Oct 6, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@askz @coveralls @frol