Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-89 [deploy/stack2] Log to file without uWSGI: #91

Conversation

MagicJohnJang
Copy link
Contributor

  • log file to /tmp/flask-stack2_{date} and rotating wihen file size over 100MB.
  • Add an unique request id to identify different request in log.

* log file to /tmp/flask-stack2_{date} and rotating wihen file size over 100MB.
* Add an unique request id to identify different request in log.
@MagicJohnJang MagicJohnJang changed the title Log to file without uWSGI: [deploy/stack2] Log to file without uWSGI: Dec 29, 2017
@MagicJohnJang MagicJohnJang changed the title [deploy/stack2] Log to file without uWSGI: Issue-89 [deploy/stack2] Log to file without uWSGI: Dec 29, 2017
@frol
Copy link
Owner

frol commented Dec 29, 2017

@MagicJohnJang Thank you for this patch!

I am sorry, but I don't think I can take it in as it increases the complexity of the example. I understand that logging is also a valuable part of any project, but this exact use-case seems to me too specific.

Still, I don't want any effort to be lost, so I will create a label with such PRs and reference them in the README.

* Remove trailing whitespace.
* Break the line too long (145/100).
Repository owner deleted a comment Jan 4, 2018
Repository owner deleted a comment Jan 4, 2018
* Break the line too long (145/100).
Repository owner deleted a comment Jan 4, 2018
@coveralls
Copy link

coveralls commented Jan 4, 2018

Coverage Status

Coverage increased (+0.02%) to 94.148% when pulling 6ba3aec on MagicJohnJang:issue-89-log-to-file-without-uwsgi into 3f3ad74 on frol:master.

@frol frol added the extension label Jan 4, 2018
@frol
Copy link
Owner

frol commented Jan 4, 2018

I have added a link to "extension" label into the README, so I am going to close this PR as is and hope someone will find your patch useful so they apply it in their projects.

@MagicJohnJang Thank you!

@frol frol closed this Jan 4, 2018
@MagicJohnJang
Copy link
Contributor Author

MagicJohnJang commented Jan 9, 2018

Hi @frol , I have a new commit in this branch to avoid building fail by docker-compose build, please help to update it, thank you~

@frol
Copy link
Owner

frol commented Jan 9, 2018

Weird. Let's try reopening the PR to see if that will pull the latest commit.

@frol frol reopened this Jan 9, 2018
@frol
Copy link
Owner

frol commented Jan 9, 2018

That helped :)

@frol frol closed this Jan 9, 2018
@coveralls
Copy link

coveralls commented Jan 9, 2018

Coverage Status

Coverage increased (+0.02%) to 94.148% when pulling 6359b50 on MagicJohnJang:issue-89-log-to-file-without-uwsgi into 3f3ad74 on frol:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants