-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-89 [deploy/stack2] Log to file without uWSGI: #91
Issue-89 [deploy/stack2] Log to file without uWSGI: #91
Conversation
MagicJohnJang
commented
Dec 29, 2017
- log file to /tmp/flask-stack2_{date} and rotating wihen file size over 100MB.
- Add an unique request id to identify different request in log.
* log file to /tmp/flask-stack2_{date} and rotating wihen file size over 100MB. * Add an unique request id to identify different request in log.
@MagicJohnJang Thank you for this patch! I am sorry, but I don't think I can take it in as it increases the complexity of the example. I understand that logging is also a valuable part of any project, but this exact use-case seems to me too specific. Still, I don't want any effort to be lost, so I will create a label with such PRs and reference them in the README. |
* Remove trailing whitespace. * Break the line too long (145/100).
* Break the line too long (145/100).
I have added a link to "extension" label into the README, so I am going to close this PR as is and hope someone will find your patch useful so they apply it in their projects. @MagicJohnJang Thank you! |
Weird. Let's try reopening the PR to see if that will pull the latest commit. |
That helped :) |