Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

fix: change focus when zoom buttons becomes disabled (fix issue #132) #135

Conversation

bastoune
Copy link
Contributor

@bastoune bastoune commented Jul 23, 2018

fix: change focus when zoom buttons becomes disabled to be able to still use arrow keys (fix issue #132)

closes #132

@bastoune bastoune changed the title fix: change focus when zoom buttons becomes disabled fix: change focus when zoom buttons becomes disabled (fix issue #132) Jul 23, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 76

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.9%) to 43.498%

Totals Coverage Status
Change from base Build 66: 2.9%
Covered Lines: 248
Relevant Lines: 555

💛 - Coveralls

Copy link
Member

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the bug fix :)

@bastoune
Copy link
Contributor Author

Hi @wuweiweiwu ,
I am currently working with my Fork but I'd like to re-use your package asap, when do you think a version with this PR will be released ?
Thanks,

@wuweiweiwu
Copy link
Member

@bastoune yep! I'll try to release a version soon! thanks for being patient

@wuweiweiwu wuweiweiwu merged commit 30ba946 into frontend-collective:master Aug 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug Request / keydown Event no more triggered after zoomin / zoomout
3 participants