Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

bug Request / keydown Event no more triggered after zoomin / zoomout #132

Closed
bastoune opened this issue Jul 23, 2018 · 0 comments · Fixed by #135
Closed

bug Request / keydown Event no more triggered after zoomin / zoomout #132

bastoune opened this issue Jul 23, 2018 · 0 comments · Fixed by #135

Comments

@bastoune
Copy link
Contributor

bastoune commented Jul 23, 2018 •
edited
Loading

use case

  • open the lightbox
  • navigate well with right/left keys
  • zoom in, zoom out to the original zoom
  • the key navigation doesn't work anymore

Some focus may be lost, i will try to find how to Fix it and make a PR about it
bastoune pushed a commit to bastoune/react-image-lightbox that referenced this issue Jul 23, 2018
fix: change focus when zoom buttons becomes disabled to be able to st…
d4d1f5f 
…ill use arrow keys (fix issue frontend-collective#132)
@bastoune bastoune mentioned this issue Jul 23, 2018
Closed
bastoune pushed a commit to bastoune/react-image-lightbox that referenced this issue Jul 23, 2018
fix: change focus when zoom buttons becomes disabled to be able to st…
17f9600 
…ill use arrow keys (fix issue frontend-collective#132)
bastoune pushed a commit to bastoune/react-image-lightbox that referenced this issue Jul 23, 2018
fix: change focus when zoom buttons becomes disabled to be able to st…
2e76e83 
…ill use arrow keys (fix issue frontend-collective#132)
@bastoune bastoune mentioned this issue Jul 23, 2018
Closed
bastoune pushed a commit to bastoune/react-image-lightbox that referenced this issue Jul 23, 2018
fix: change focus when zoom buttons becomes disabled to be able to st…
421cc08 
…ill use arrow keys (fix issue frontend-collective#132)
bastoune pushed a commit to bastoune/react-image-lightbox that referenced this issue Jul 23, 2018
fix: change focus when zoom buttons becomes disabled to be able to st…
320b9e2 
…ill use arrow keys (fix issue frontend-collective#132)
@bastoune bastoune mentioned this issue Jul 23, 2018
Merged
wuweiweiwu pushed a commit that referenced this issue Aug 30, 2018
@wuweiweiwu
fix: change focus when zoom buttons becomes disabled to be able to st…
30ba946 
…ill use arrow keys (fix issue #132) (#135)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: change focus when zoom buttons becomes disabled (fix issue #132) bastoune/react-image-lightbox
1 participant
@bastoune