Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

NaN is an invalid value for the height css style property. Check the render method of ReactImageLightbox #59

Closed
Stupidism opened this issue Jun 28, 2017 · 1 comment · Fixed by #67
Closed

NaN is an invalid value for the height css style property. Check the render method of ReactImageLightbox #59

Stupidism opened this issue Jun 28, 2017 · 1 comment · Fixed by #67

Comments

@Stupidism
Copy link

This warning occurred in test environment.

console.error node_modules/fbjs/lib/warning.js:36
      Warning: `NaN` is an invalid value for the `height` css style property. Check the render method of `ReactImageLightbox`.

Reproduce

git clone git@github.com:ClarityMovement/clarity-components.git 
cd clarity-components && yarn install
yarn run test
@leoek leoek mentioned this issue Sep 6, 2017
Closed
leoek added a commit to leoek/react-image-lightbox that referenced this issue Sep 6, 2017
@leoek
fixed issue frontend-collective#59 and frontend-collective#65
dd47dbb
@leoek leoek mentioned this issue Sep 6, 2017
Merged
fritz-c added a commit that referenced this issue Sep 6, 2017
@fritz-c
Merge pull request #66 from leoek/master
4a53728 
This fixes the warinings about the css property width/height being Nan. (issue #59 and #65)
@fritz-c
Copy link
Member

fritz-c commented Sep 6, 2017

This should be fixed now in v4.2.0

@fritz-c fritz-c closed this as completed Sep 6, 2017
leoek added a commit to leoek/react-image-lightbox that referenced this issue Sep 7, 2017
@leoek
correcting a mistake from pull reequest frontend-collective#66, i int…
baccb9f 
…ended to set the width and height property to 'null' but unfortunately wrote 0 -.- therefore frontend-collective#66 fixed frontend-collective#59 and frontend-collective#65 but the images height and width are not available for (yet) wont be displayed at all.
@leoek leoek mentioned this issue Sep 7, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

correction for pull request #66, use 'null' instead of '0' leoek/react-image-lightbox
2 participants
@fritz-c @Stupidism