This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Custom template and improvements #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2017
gido
reviewed
Oct 24, 2017
tasks/prepare.js
Outdated
| .pipe($.replace('{/* COLORS */}', JSON.stringify(JSON.parse(colors)))) | ||
| $.util.log('Using template', $.util.colors.magenta(config.custom_template || config.template)); | ||
|
|
||
| return gulp.src(config.custom_template || config.template, { cwd: config.custom_template ? config.project : '' }) |
There was a problem hiding this comment.
Why using two variables config.custom_template and config.template ?
What about checking if a pre-defined custom template exist and if yes, override config.template ?
We can also create a dedicated config for the Current Working Directory instead of deducting that if there is a custom template it is inside the project dir...
There was a problem hiding this comment.
I need this cwd parameter for Gulp 🤔
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #14 and close #15