New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Slot component #90
Conversation
Assigned @mburridge cause you're the supporter this week 馃檪 |
Hey Michal, I think you've mistakenly added this to Also, as this is not ready yet, I'm going to turn it into a draft 馃憤 |
Just to add more context about this According to the latest Sprint (Sprint 4) status
This feature is finished but it's not released yet The code PR is merged but the Feature Discussion is still as "Currently in Development" until the feature is released |
Hey @mburridge let me know if you need help or more information to finish the documentation here 馃檪 |
@michalczaplinski A quick question: Were data assertions implemented (as described at https://community.frontity.org/t/slot-and-fill/895/3)? Do they need documenting? |
yes, it should also be documented. Mind, that there already exists some basic documentation for it: https://docs.frontity.org/api-reference-1/frontity#usefills I think the hook will be used less often than the Slot component, because I think that in most cases the I ll leave it up to you to decide where and how to document that 馃檪
Nope, they were not implemented yet so no docs needed 馃檪 . I've updated the announcement on the forum to clarify that: https://community.frontity.org/t/slot-and-fill/895/19 |
I found the useFills docs so edited my question to remove that. Let me know if more content is needed there. I think you were probably answering just as I edited the question! 馃槃 I've opened a new PR for this now: #168 |
This is the documentation for the
<Slot/>
component.Feature Discussion: https://community.frontity.org/t/slot-and-fill/895
PR into
frontity/frontity
: frontity/frontity#475This is not complete yet. We're missing:
useFills
hook聽#75 (comment))library
property refers toFills
(e.g by settingstate.fills.fillNamespace.fillName.props
)priority
in the same slotetc.
Admittedly, some of the above are more related to how to use the Slot and fill pattern in general.
Let me know if you guys would need more help with this 馃檪