Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Frontity #25

Merged
merged 3 commits into from Mar 4, 2020
Merged

Update Frontity #25

merged 3 commits into from Mar 4, 2020

Conversation

SantosGuillamot
Copy link
Member

I've just run the commands to update Frontity, so we have the latest changes available, mainly the ones affecting html2react. Not 100% if anything else is needed, apart from merging dev into the branches affected once the changes are made.

@SantosGuillamot
Copy link
Member Author

@luisherranz I've already updated the dependencies for the local package, delete the package-lock.json and run npm install again. Could you take a look and check if there's anything left?

Now that we fixed the problem with @frontity/connect we should not need to
use peerDependencies.
Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I have moved the peerDependencies to normal dependencies now that we found the root of the problem with the updates because back then I thought it should be solved using peer dependencies. But not anymore 😆

Feel free to merge.

@SantosGuillamot SantosGuillamot merged commit 532c138 into dev Mar 4, 2020
@luisherranz luisherranz deleted the update-frontity branch March 4, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants