-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newsletter logic #75
Newsletter logic #75
Conversation
Deploy preview for website ready! Built with commit a483e4a |
I've left only the components in the components folder and moved actions and state to the root. We don't use the name "store" anymore to avoid introducing an additional concept, just actions and state.
Typings were declared but not being used.
The union was not working so I divided them into 2 different functions
Nice work @SantosGuillamot! I have refactored the code to help you structure things a little better. Also, typescript was right but it was not being applied. Take a look at the commits and commit messages and if you have any question let me know 👍 |
@SantosGuillamot Leaving this in blocked for the moment as it's waiting on frontity/frontity#371 in order to send the correct events The UI should be good to go if you want to review it though (it didn't require that many changes, actually🙂) |
Looks great Michal! Some minor details that I'd implement if they aren't too difficult:
|
Newsletter gtm
In order to test if the old logic was reusable I kind of migrated to the new web, in case it's useful for the final implementation. It works except some things I'm aware that should be improved: