CLI: Add theme param to create

[michalczaplinski]

Description of what you did:

This PR adds the ability to pick a theme when running the frontity create.

• A new option --theme which allows specifying the starter theme on the command line.
• If the theme is not specified, the user can pick a theme from an interactive prompt
• If the command is run with --no-prompt, fall back to the default theme (mars-theme)

(A few unrelated and small improvements to the tests for the CLI also made it here, by the way)

My PR is a:

• 🚀 New feature

Is the PR ready to be merged?

• 🚧 Work in progress

---

Fixes #132

[changeset-bot]

🦋 Changeset is good to go

Latest commit: 7e5616d

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[DAreRodz]

Hey Michal!

There is a problem with the create command. When you select a different theme than mars-theme the frontity.settings.js file won't include the theme you choose but mars. It's the createFrontitySettings function (that is being called here). Could you change that function and add some tests?

Code looks fine, by the way. 😊

[luisherranz]

I've been thinking about this during the last few days and I think we can solve it using the frontity.config.js file: https://community.frontity.org/t/defining-default-settings-for-frontity-packages/1139

Please read that feature topic and let me know what you think (in the topic).

[michalczaplinski]

There is a problem with the create command. When you select a different theme than mars-theme the frontity.settings.js file won't include the theme you choose but mars. It's the createFrontitySettings function (that is being called here).

oh, nice catch @DAreRodz, thanks! 🙂

[luisherranz]

Yeah, that is actually the bug!
#132

Sorry we forgot to add it to the sprint. I've done so now and added a Fixes to this PR.

[DAreRodz]

Looks good to me! 👌

[DAreRodz]

PS: I guess the default settings feature would be implemented in another PR. This is totally fine, isn't it?

[luisherranz]

Great work @michalczaplinski!

[luisherranz]

PS: I guess the default settings feature would be implemented in another PR. This is totally fine, isn't it?

Yeah, I guess this is fine for now.

For reference, this should be the next step: https://community.frontity.org/t/defining-default-settings-for-frontity-packages/1139/3