Migrate Frontity Connect to react easy state [21pt] #415

luisherranz · 2020-05-04T15:41:13Z

What:

Stop using our own fork and migrate back to react-easy-state.

Why:

Because they are adding hooks to their library, so we can build on top of it. This means that Frontity Connect will become an opinionated version of react-easy-state instead of a fork.

How:

I removed all our code, added react-easy-state back and used the hooks to replicate our changes.

Tasks:

Unrelated:

Migrate to TypeScript.
Open new FD for the refactor of the TypeScript.
Use batch() to batch invalidations of observe as well.
Refactor general TypeScript (can check this https://github.com/frontity/frontity/blob/connect-middleware/packages/connect/types.ts).
Run performance check in https://github.com/krausest/js-framework-benchmark
~~Update starter themes~~
~~Update other packages~~
~~Documentation~~
~~Community discussions~~

changeset-bot · 2020-05-04T15:41:15Z

🦋 Changeset detected

Latest commit: a86e636

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

TSDocs disabled by `@luisherranz` in this file because he needs to figure out first which types will remain when we merge this PR #415, taking into account that `react-easy-state` and `@nx-js/observer-util` already have types themselves.

Because I want to refactor those types in the #415 PR.

github-actions · 2020-07-31T15:03:40Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	8	8
Warnings	0	0
Ignored	0	N/A

Result: ❌ failure
Annotations: 8 total

[failure] jsdoc/require-param

Requires that all function parameters are documented.

packages/connect/src/connect.js Line 28 - Missing JSDoc @param "options" declaration.

[failure] jsdoc/require-jsdoc

Require JSDoc comments

packages/connect/src/connect.js Line 54 - Missing JSDoc comment.
packages/connect/src/connect.js Line 57 - Missing JSDoc comment.
packages/connect/src/connect.js Line 69 - Missing JSDoc comment.
packages/connect/src/create-store.js Line 9 - Missing JSDoc comment.
packages/connect/src/create-store.js Line 29 - Missing JSDoc comment.
packages/connect/src/create-store.js Line 46 - Missing JSDoc comment.
packages/connect/src/create-store.js Line 82 - Missing JSDoc comment.

^{Report generated by eslint-plus-action}

codecov · 2020-07-31T20:19:58Z

Codecov Report

Merging #415 (a86e636) into dev (d0faec5) will decrease coverage by 1.49%.
The diff coverage is 96.37%.

Impacted Files	Coverage Δ
packages/connect/src/create-store.js	`91.67% <95.46%> (ø)`
packages/connect/src/connect.js	`75.37% <96.97%> (+10.43%)`	⬆️

github-actions · 2020-08-04T15:33:00Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	4	4
Warnings	0	0
Ignored	0	N/A

Result: ❌ failure
Annotations: 4 total

[failure] jsdoc/require-param

Requires that all function parameters are documented.

packages/connect/src/connect.js Line 28 - Missing JSDoc @param "options" declaration.

[failure] jsdoc/require-jsdoc

Require JSDoc comments

packages/connect/src/connect.js Line 54 - Missing JSDoc comment.
packages/connect/src/connect.js Line 57 - Missing JSDoc comment.
packages/connect/src/connect.js Line 69 - Missing JSDoc comment.

^{Report generated by eslint-plus-action}

luisherranz · 2020-08-04T16:12:46Z

I have updated the code to use the last alpha versions from react-easy-state and @nx-js/observer-util. I've also merged it with the new useConnect hook.

luisherranz · 2021-04-14T13:26:31Z

This is finally ready for review 🙂

I've made a video to go over the changes: https://www.loom.com/share/e48c9accaabd4b69b8f4cc2349ed997e

michalczaplinski

I haven't finished reviewing it all but I have some questions in the meantime 🙂

.changeset/forty-mayflies-joke.md

packages/connect/src/__tests__/types.tests.tsx

packages/connect/src/connect.js

packages/connect/package.json

…state

luisherranz · 2021-04-15T07:51:18Z

Thanks for the reviews guys. I've made the changes and should be up for a review again 🙂

github-actions · 2021-04-15T07:53:04Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

michalczaplinski · 2021-04-16T02:09:18Z

packages/connect/src/connect.js

+            scheduler: () => {
+              // Trigger a new rerender if the component has already been
+              // mounted.
+              if (reaction.current.mounted) setState({});
+              // Annotate it as "changed" if the component has not been mounted
+              // yet.
+              else reaction.current.changedBeforeMounted = true;
+            },


Note to self: The custom scheduler is used here in order to fix the bug: RisingStack/react-easy-state#196 (comment)

github-actions · 2021-04-16T02:13:50Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

michalczaplinski

OK, looks great @luisherranz 🙂 Let's merge this!

luisherranz · 2021-04-16T07:56:49Z

Merged! Thanks a lot guys! 🙂

luisherranz added 2 commits May 4, 2020 13:43

Connect: Migrate create-store to react-easy-state

9a5c6f9

Connect: Use RES view inside connect()

d2da4c3

luisherranz self-assigned this May 4, 2020

luisherranz added 2 commits May 4, 2020 19:38

Don't hardcode root state

8e2f7bb

Remove temporary fix

1ae93bd

frontity deleted a comment from sonarcloud bot May 4, 2020

luisherranz changed the title ~~Migrate Frontity Connect to react easy state~~ WIP: Migrate Frontity Connect to react easy state May 4, 2020

luisherranz marked this pull request as draft May 6, 2020 05:37

luisherranz changed the title ~~WIP: Migrate Frontity Connect to react easy state~~ Migrate Frontity Connect to react easy state May 6, 2020

luisherranz mentioned this pull request Jun 26, 2020

Update connect with upstream fixes #342

Closed

5 tasks

frontity deleted a comment from sonarcloud bot Jun 26, 2020

This was referenced Jun 29, 2020

Fix connect options types #508

Merged

Feature/link component #507

Merged

luisherranz added a commit that referenced this pull request Jul 2, 2020

TSDocs: disable on connect types

ee2bbeb

Because I want to refactor those types in the #415 PR.

This was referenced Jul 27, 2020

React composition events not working properly on controlled input fields (this events are needed to write languages like Japanese) #519

Closed

Cursor jumps to end of input fields #236

Closed

luisherranz linked an issue Jul 27, 2020 that may be closed by this pull request

Cursor jumps to end of input fields #236

Closed

3 tasks

Merge branch 'dev' into migrate-to-react-easy-state

34ec130

Fix isConnected flag

e62d3ff

luisherranz added 2 commits August 4, 2020 17:19

Update to the latest alpha of RES

ace4639

Get rid of the weak map and use an internal reference

4eb34c8

Merge branch 'dev' into migrate-to-react-easy-state

2ed9e75

luisherranz mentioned this pull request Aug 11, 2020

Google Tag Manager click events aren't working in @frontity/google-tag-manager-analytics #536

Closed

Connect: Pass only state, actions and libraries

34bac0a

Merge branch 'dev' into migrate-to-react-easy-state

e9a8f94

luisherranz marked this pull request as ready for review April 14, 2021 13:25

luisherranz requested a review from DAreRodz April 14, 2021 13:25

luisherranz requested review from michalczaplinski and removed request for DAreRodz April 14, 2021 13:30

michalczaplinski reviewed Apr 15, 2021

View reviewed changes

cristianbote reviewed Apr 15, 2021

View reviewed changes

packages/connect/package.json Outdated Show resolved Hide resolved

luisherranz added 6 commits April 15, 2021 09:17

Improve changeset message

218fde5

Remove unnecessary eslint disables

7ffea96

Remove unnecessary React import

9546f16

Rename isStatelessComp to isFunctionalComp

242814b

Unfix react-easy-state deps

f4f2405

Merge remote-tracking branch 'origin/dev' into migrate-to-react-easy-…

3cbbd18

…state

luisherranz requested a review from michalczaplinski April 15, 2021 07:50

michalczaplinski moved this from In progress to In review in Sprint 13 Apr 15, 2021

michalczaplinski reviewed Apr 16, 2021

View reviewed changes

michalczaplinski added 2 commits April 15, 2021 21:11

Fix the spelling of initialize in a comment

f967e59

Merge branch 'dev' into migrate-to-react-easy-state

3083d6f

michalczaplinski self-requested a review April 16, 2021 02:12

michalczaplinski approved these changes Apr 16, 2021

View reviewed changes

Merge branch 'dev' into migrate-to-react-easy-state

a86e636

luisherranz merged commit 750a368 into dev Apr 16, 2021

Sprint 13 automation moved this from In review to Done Apr 16, 2021

luisherranz deleted the migrate-to-react-easy-state branch April 16, 2021 07:56

SantosGuillamot mentioned this pull request Apr 26, 2021

Version Packages #802

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Frontity Connect to react easy state [21pt] #415

Migrate Frontity Connect to react easy state [21pt] #415

luisherranz commented May 4, 2020 •

edited

Loading

changeset-bot bot commented May 4, 2020 •

edited

Loading

github-actions bot commented Jul 31, 2020 •

edited

Loading

codecov bot commented Jul 31, 2020 •

edited

Loading

github-actions bot commented Aug 4, 2020 •

edited

Loading

luisherranz commented Aug 4, 2020

luisherranz commented Apr 14, 2021

michalczaplinski left a comment

luisherranz commented Apr 15, 2021

github-actions bot commented Apr 15, 2021

michalczaplinski Apr 16, 2021

github-actions bot commented Apr 16, 2021 •

edited

Loading

michalczaplinski left a comment

luisherranz commented Apr 16, 2021

Migrate Frontity Connect to react easy state [21pt] #415

Migrate Frontity Connect to react easy state [21pt] #415

Conversation

luisherranz commented May 4, 2020 • edited Loading

changeset-bot bot commented May 4, 2020 • edited Loading

🦋 Changeset detected

github-actions bot commented Jul 31, 2020 • edited Loading

ESLint Summary View Full Report

[failure] jsdoc/require-param

[failure] jsdoc/require-jsdoc

codecov bot commented Jul 31, 2020 • edited Loading

Codecov Report

github-actions bot commented Aug 4, 2020 • edited Loading

ESLint Summary View Full Report

[failure] jsdoc/require-param

[failure] jsdoc/require-jsdoc

luisherranz commented Aug 4, 2020

luisherranz commented Apr 14, 2021

michalczaplinski left a comment

Choose a reason for hiding this comment

luisherranz commented Apr 15, 2021

github-actions bot commented Apr 15, 2021

ESLint Summary View Full Report

michalczaplinski Apr 16, 2021

Choose a reason for hiding this comment

github-actions bot commented Apr 16, 2021 • edited Loading

ESLint Summary View Full Report

michalczaplinski left a comment

Choose a reason for hiding this comment

luisherranz commented Apr 16, 2021

luisherranz commented May 4, 2020 •

edited

Loading

changeset-bot bot commented May 4, 2020 •

edited

Loading

github-actions bot commented Jul 31, 2020 •

edited

Loading

codecov bot commented Jul 31, 2020 •

edited

Loading

github-actions bot commented Aug 4, 2020 •

edited

Loading

github-actions bot commented Apr 16, 2021 •

edited

Loading