New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @frontity/google-analytics to work with the new GA4 format #733
Conversation
🦋 Changeset detectedLatest commit: 7e80738 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cristianbote, the e2e tests are failing. Can you please check it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sorry for my other message. I think this should work great for both the new events and the category/label ones.
Code is great, and Cristian even added an e2e test that sends a custom payload.
Everything perfect then! Thanks Cris!! 😄👏
@cristianbote or @luisherranz As per this post I understand there's some documentation to be done here |
Cris and Mario are talking about this in the initial Google Analytics FD: https://community.frontity.org/t/google-analytics-package/1084/19?u=luisherranz |
This change will require a major version bump for
@frontity/google-analytics
since the ways of handling pageviews and event data has changed.What:
Update @frontity/google-analytics to work with the new GA4.
Why:
GA4 introduces a new way of sending events and pageview data.
Tasks:
Unrelated Tasks
Additional Comments