Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @frontity/google-analytics to work with the new GA4 format #733

Merged
merged 5 commits into from Mar 2, 2021

Conversation

cristianbote
Copy link
Member

@cristianbote cristianbote commented Mar 1, 2021

This change will require a major version bump for @frontity/google-analytics since the ways of handling pageviews and event data has changed.

What:

Update @frontity/google-analytics to work with the new GA4.

Why:

GA4 introduces a new way of sending events and pageview data.

Tasks:

  • Code
  • TypeScript
  • Unit tests
  • TypeScript tests
  • Update other packages
  • Add a changeset (with link to its Feature Discussion if it exists)

Unrelated Tasks

  • TSDocs
  • End to end tests
  • Update starter themes
  • Update community discussions

Additional Comments

@cristianbote cristianbote self-assigned this Mar 1, 2021
@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2021

🦋 Changeset detected

Latest commit: 7e80738

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@frontity/google-analytics Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #733 (7e80738) into dev (8d03a72) will decrease coverage by 0.11%.
The diff coverage is 16.67%.

Impacted Files Coverage Δ
packages/google-analytics/src/index.ts 0.00% <0.00%> (-29.16%) ⬇️
packages/google-analytics/src/components/index.tsx 100.00% <100.00%> (ø)

Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristianbote, the e2e tests are failing. Can you please check it out?

Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sorry for my other message. I think this should work great for both the new events and the category/label ones.

Code is great, and Cristian even added an e2e test that sends a custom payload.

Everything perfect then! Thanks Cris!! 😄👏

@SantosGuillamot SantosGuillamot merged commit 66a4d75 into dev Mar 2, 2021
@SantosGuillamot SantosGuillamot deleted the frontity-google-analytics-4 branch March 2, 2021 07:59
@frontibotito frontibotito mentioned this pull request Mar 2, 2021
@juanmaguitar
Copy link
Member

@cristianbote or @luisherranz
Is there a FD for this?
Are there new features that require some documentation? In that case, Is there a documentation issue created?

As per this post I understand there's some documentation to be done here

@luisherranz
Copy link
Member

Cris and Mario are talking about this in the initial Google Analytics FD: https://community.frontity.org/t/google-analytics-package/1084/19?u=luisherranz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@frontity/google-analytics package doesn't work with Google Analytics 4 [5pt]
4 participants