Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for passing classname to the DOM in WebComponents created with Html2React #741

Merged
merged 10 commits into from Mar 10, 2021
Merged

Fix for passing classname to the DOM in WebComponents created with Html2React #741

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f707169
Create test case for passing className to web component
michalczaplinski Mar 9, 2021
3285141
Add @emotion/css and fix the issue
michalczaplinski Mar 9, 2021
c326111
Add changeset
michalczaplinski Mar 9, 2021
6c72675
Add better comments
michalczaplinski Mar 9, 2021
e69beba
Add the fix for classNames in custom components
michalczaplinski Mar 10, 2021
9a7fef6
Add better comments
michalczaplinski Mar 10, 2021
5ea817f
Add better comment
michalczaplinski Mar 10, 2021
e7d9ea0
Improve comments again
michalczaplinski Mar 10, 2021
78cc7dc
Change implementation to use Wrapper component
michalczaplinski Mar 10, 2021
41a3fc4
Add multiple props to the test
michalczaplinski Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thin-pumas-design.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"@frontity/html2react": patch
---

Fix a bug causing Custom Components processed with Html2React to pass a `className` prop to DOM nodes.