Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workspaces from package.json #781

Merged
merged 2 commits into from Apr 13, 2021
Merged

Conversation

luisherranz
Copy link
Member

@luisherranz luisherranz commented Apr 13, 2021

What:

Remove the workspaces property of our package.json.

Why:

Fixes #780.

Because we are still using lerna for the monorepo, but npm v7 thinks that we are using its workspaces and tries to install them but it fails.

@michalczaplinski reported a bug related to that: npm/cli#3065

We had that property defined because Changesets don't read the workspace from lerna, but from the package.json. But Changesets only uses that workspace information to populate the package names when running npx changeset and without it outputs everything, so it is not required, just nice to have.

How:

Simply removing the workspaces property.

Tasks:

  • Change package.json

Unrelated Tasks

  • Code
  • TSDocs
  • TypeScript
  • Unit tests
  • End to end tests
  • TypeScript tests
  • Update starter themes
  • Update other packages
  • Update community discussions
  • Add a changeset (with link to its Feature Discussion if it exists)

@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2021

⚠️ No Changeset found

Latest commit: e7f3203

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #781 (e7f3203) into dev (9696382) will not change coverage.
The diff coverage is n/a.

@luisherranz luisherranz changed the title Remove workspaces Remove workspaces from package.json Apr 13, 2021
Copy link
Member

@michalczaplinski michalczaplinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michalczaplinski michalczaplinski merged commit 8633ba3 into dev Apr 13, 2021
@michalczaplinski michalczaplinski deleted the remove-workspaces branch April 13, 2021 18:40
@github-actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm install fails after cloning a repo
2 participants