Remove workspaces from package.json #781
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove the
workspaces
property of ourpackage.json
.Why:
Fixes #780.
Because we are still using
lerna
for the monorepo, butnpm
v7 thinks that we are using its workspaces and tries to install them but it fails.@michalczaplinski reported a bug related to that: npm/cli#3065
We had that property defined because Changesets don't read the workspace from
lerna
, but from thepackage.json
. But Changesets only uses that workspace information to populate the package names when runningnpx changeset
and without it outputs everything, so it is not required, just nice to have.How:
Simply removing the
workspaces
property.Tasks:
package.json
Unrelated Tasks