New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transpile all frontity.settings/config imports #837
Conversation
🦋 Changeset detectedLatest commit: 039d6fd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
I'm not sure why the CLI tests keep failing occasionally and only on MacOS. I thought this should have been fixed in #824. |
True. It seems like this time was a timeout. We'll keep an eye on them 🙂 I have rerun them and they passed this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems just fine to me. 👍
Although for me it's not clear the part of not ignoring packages with frontity
. Would it mean that some frontity packages (those imported by frontity settings/config files) should contain frontity
in their name?
It is a compromise between transpiling everything (which is pretty slow) and not transpiling anything, which could lead to problems like the one this PR is trying to solve. I tried to come up with a set of scenarios where transpiling seems more right than wrong. EDIT: I think I didn't address your question:
The answer is no, they don't need to contain |
What:
Change the files that the
ts-node
that we run in thedev
andbuild
commands transpile.Why:
Because it was not transpiling files that were inside the
node_modules
folder, likefrontity.config.js
files in external packages.How:
I created a regular expression that is passed to the
ignores
setting ofts-node
and makes it transpile only:@frontity
orgfrontity
in the name (for examplesome-frontity-package
).frontity.settings
filesfrontity.config
filesBy default this setting was
node_modules
.This
ts-node
transpilation is only used outside of Webpack, which means mostly things people import in theirfrontity.settings
orfrontity.config
files. Once Webpack runs, all the files are transpiled.Tasks:
Unrelated Tasks