Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pnpm support #9

Closed
zkochan opened this issue Jan 13, 2018 · 2 comments · Fixed by #10
Closed

Adding pnpm support #9

zkochan opened this issue Jan 13, 2018 · 2 comments · Fixed by #10

Comments

@zkochan
Copy link
Contributor

zkochan commented Jan 13, 2018

Adding pnpm support should be really easy.

I see currently this tool checks for a lockfile to decide what pm should be used for installation. pnpm has its own lockfile called shrinkwrap.yaml.

Alternatively, which-pm can be used, which will correctly identify the pm even when installing was done w/o a lockfile creation

@frontsideair
Copy link
Owner

Both ideas sound great, but let's handle them separately. Would you like to implement pnpm support? I can do that if you'd not prefer to. A separate issue would be great for adding which-pm dependency, which I have briefly checked yet, but looks solid.

@zkochan
Copy link
Contributor Author

zkochan commented Jan 13, 2018

great, I'll create a PR

zkochan added a commit to zkochan/yarnhook that referenced this issue Jan 13, 2018
frontsideair pushed a commit that referenced this issue Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants