Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup readme, add breaking change warning #751

Merged
merged 2 commits into from Aug 17, 2023
Merged

Cleanup readme, add breaking change warning #751

merged 2 commits into from Aug 17, 2023

Conversation

fronzbot
Copy link
Owner

Description:

Brush up the async examples in the README and add a nice fat warning at the top

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #751 (31ce2d4) into dev (6b38fd4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #751   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files           8        8           
  Lines        1424     1424           
=======================================
  Hits         1419     1419           
  Misses          5        5           
Flag Coverage Δ
unittests 99.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mkmer
Copy link
Contributor

mkmer commented Aug 17, 2023

Sorry I didn't do justice on this - docs/readme files are the last thing on a developers mind :)

@fronzbot fronzbot merged commit f231f22 into dev Aug 17, 2023
8 checks passed
@fronzbot fronzbot deleted the cleanup-readme branch August 17, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants