Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery level #837

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Battery level #837

merged 6 commits into from
Jan 2, 2024

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jan 2, 2024

Description:

Change name of battery_voltage to battery_level
Update camera tests and utilize constant for CONFIG

Related issue (if applicable): fixes #

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (738a93a) 99.86% compared to head (d48b507) 99.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #837      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files           8        8              
  Lines        1458     1457       -1     
==========================================
- Hits         1456     1455       -1     
  Misses          2        2              
Flag Coverage Δ
unittests 99.86% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkmer
Copy link
Contributor Author

mkmer commented Jan 2, 2024

Do we really still need py38?

@fronzbot
Copy link
Owner

fronzbot commented Jan 2, 2024

No we do not need py38. If something is failing as a result, I'm 100% ok with deprecating 3.8 support

@mkmer
Copy link
Contributor Author

mkmer commented Jan 2, 2024

It's ok - I was using | in dictionaries for the tests. Moved to {**x,**y} which is 3.8 compatible.
There was a reused "constant" that I was going to touch to many times, so I "simplified" it.

@fronzbot fronzbot merged commit 0849f63 into fronzbot:dev Jan 2, 2024
8 checks passed
@mkmer mkmer deleted the battery_level branch January 3, 2024 12:23
@mkmer
Copy link
Contributor Author

mkmer commented Jan 4, 2024

At some point we will need to do a release to fix the HA wifi sensor issue.
There is a bit of noise on 2FA right now, so maybe we hold off just a bit to see if something has changed on the Blink side....

@fronzbot
Copy link
Owner

fronzbot commented Jan 4, 2024

Yeah saw that. Let's give it till the weekend and I'll make a release after that (feel free to ping me if you don't see anything)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants