Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to change agent from Auth() init #860

Merged
merged 1 commit into from Jan 13, 2024

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jan 13, 2024

Description:

A little forward thinking (maybe) - allow calling app to set agent and app_build as optional keys.
I have a feeling we will need to change this more often than not.

Related issue (if applicable): fixes #

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d83708) 99.86% compared to head (ec8f682) 99.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #860   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files           8        8           
  Lines        1477     1477           
=======================================
  Hits         1475     1475           
  Misses          2        2           
Flag Coverage Δ
unittests 99.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fronzbot fronzbot merged commit c899cf4 into fronzbot:dev Jan 13, 2024
8 checks passed
@fronzbot
Copy link
Owner

Yeah makes sense to me

@mkmer mkmer deleted the optional-agent branch January 13, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants