Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New temperature location #867

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jan 22, 2024

Description:

Based on issue #865
Temperature has also moved to the signals

Related issue (if applicable): fixes #

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5146b36) 99.79% compared to head (a93e242) 99.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #867   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files           8        8           
  Lines        1481     1482    +1     
=======================================
+ Hits         1478     1479    +1     
  Misses          3        3           
Flag Coverage Δ
unittests 99.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fronzbot fronzbot merged commit df31ee7 into fronzbot:dev Jan 25, 2024
8 checks passed
@mkmer mkmer deleted the New-temperature-location branch January 25, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants