Added ability to rollback virtual box host only network configuration #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. I presume this change is version independent? I know my scripts fail at 1.3.x but the resetting of vbox hostonly is not tied to docker. Am i right? |
|
I do believe it is version independent, it is just fixing the VirtualBox host-only network settings back to their defaults. |
frosenberg
added a commit
that referenced
this pull request
Nov 18, 2014
Added ability to rollback virtual box host only network configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rollback mechanism should limit exposure to the boot2docker/boot2docker#628 issue if attempted against docker 1.3.0. Realistically though this should help mitigate problems with any failed virtual box host-only network modification failures.