[common][fmp4] Important optimization to write entry based boxes in c…

…hunks (less actual disk write)

common/src/main/java/com/frostwire/fmp4/ChunkOffsetBox.java

@@ -24,7 +24,7 @@
  * @author gubatron
  * @author aldenml
  */
-public final class ChunkOffsetBox extends FullBox {
+public final class ChunkOffsetBox extends EntryBaseBox {
 
     protected int entry_count;
     protected Entry[] entries;
@@ -49,16 +49,25 @@ void read(InputChannel ch, ByteBuffer buf) throws IOException {
     }
 
     @Override
-    void write(OutputChannel ch, ByteBuffer buf) throws IOException {
-        super.write(ch, buf);
-
+    void writeFields(OutputChannel ch, ByteBuffer buf) throws IOException {
         buf.putInt(entry_count);
         IO.write(ch, 4, buf);
-        for (int i = 0; i < entry_count; i++) {
-            Entry e = entries[i];
-            buf.putInt(e.chunk_offset);
-            IO.write(ch, 4, buf);
-        }
+    }
+
+    @Override
+    int entryCount() {
+        return entry_count;
+    }
+
+    @Override
+    int entrySize() {
+        return 4;
+    }
+
+    @Override
+    void putEntry(int i, ByteBuffer buf) {
+        Entry e = entries[i];
+        buf.putInt(e.chunk_offset);
     }
 
     @Override

common/src/main/java/com/frostwire/fmp4/EntryBaseBox.java

@@ -0,0 +1,69 @@
+/*
+ * Created by Angel Leon (@gubatron), Alden Torres (aldenml)
+ * Copyright (c) 2011-2016, FrostWire(R). All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.frostwire.fmp4;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+
+/**
+ * @author gubatron
+ * @author aldenml
+ */
+public class EntryBaseBox extends FullBox {
+
+    EntryBaseBox(int type) {
+        super(type);
+    }
+
+    @Override
+    final void write(OutputChannel ch, ByteBuffer buf) throws IOException {
+        super.write(ch, buf);
+
+        writeFields(ch, buf);
+        int entry_count = entryCount();
+        int entry_size = entrySize();
+
+        if (entry_count > 0) {
+            for (int i = 0; i < entry_count; i++) {
+                if (buf.position() > 0 && buf.remaining() < entry_size) {
+                    IO.write(ch, buf.position(), buf);
+                }
+                putEntry(i, buf);
+            }
+            if (buf.position() > 0) {
+                IO.write(ch, buf.position(), buf);
+            }
+        }
+    }
+
+    void writeFields(OutputChannel ch, ByteBuffer buf) throws IOException {
+        throw new UnsupportedOperationException(Bits.make4cc(type));
+    }
+
+    int entryCount() {
+        throw new UnsupportedOperationException(Bits.make4cc(type));
+    }
+
+    int entrySize() {
+        throw new UnsupportedOperationException(Bits.make4cc(type));
+    }
+
+    void putEntry(int i, ByteBuffer buf) {
+        throw new UnsupportedOperationException(Bits.make4cc(type));
+    }
+}

common/src/main/java/com/frostwire/fmp4/SampleSizeBox.java

@@ -24,7 +24,7 @@
  * @author gubatron
  * @author aldenml
  */
-public final class SampleSizeBox extends FullBox {
+public final class SampleSizeBox extends EntryBaseBox {
 
     protected int sample_size;
     protected int sample_count;
@@ -53,19 +53,26 @@ void read(InputChannel ch, ByteBuffer buf) throws IOException {
     }
 
     @Override
-    void write(OutputChannel ch, ByteBuffer buf) throws IOException {
-        super.write(ch, buf);
-
+    void writeFields(OutputChannel ch, ByteBuffer buf) throws IOException {
         buf.putInt(sample_size);
         buf.putInt(sample_count);
         IO.write(ch, 8, buf);
-        if (entries != null) {
-            for (int i = 0; i < sample_count; i++) {
-                Entry e = entries[i];
-                buf.putInt(e.entry_size);
-                IO.write(ch, 4, buf);
-            }
-        }
+    }
+
+    @Override
+    int entryCount() {
+        return entries != null ? sample_count : 0;
+    }
+
+    @Override
+    int entrySize() {
+        return 4;
+    }
+
+    @Override
+    void putEntry(int i, ByteBuffer buf) {
+        Entry e = entries[i];
+        buf.putInt(e.entry_size);
     }
 
     @Override

common/src/main/java/com/frostwire/fmp4/SampleToChunkBox.java

@@ -24,7 +24,7 @@
  * @author gubatron
  * @author aldenml
  */
-public final class SampleToChunkBox extends FullBox {
+public final class SampleToChunkBox extends EntryBaseBox {
 
     protected int entry_count;
     protected Entry[] entries;
@@ -51,18 +51,27 @@ void read(InputChannel ch, ByteBuffer buf) throws IOException {
     }
 
     @Override
-    void write(OutputChannel ch, ByteBuffer buf) throws IOException {
-        super.write(ch, buf);
-
+    void writeFields(OutputChannel ch, ByteBuffer buf) throws IOException {
         buf.putInt(entry_count);
         IO.write(ch, 4, buf);
-        for (int i = 0; i < entry_count; i++) {
-            Entry e = entries[i];
-            buf.putInt(e.first_chunk);
-            buf.putInt(e.samples_per_chunk);
-            buf.putInt(e.sample_description_index);
-            IO.write(ch, 12, buf);
-        }
+    }
+
+    @Override
+    int entryCount() {
+        return entry_count;
+    }
+
+    @Override
+    int entrySize() {
+        return 12;
+    }
+
+    @Override
+    void putEntry(int i, ByteBuffer buf) {
+        Entry e = entries[i];
+        buf.putInt(e.first_chunk);
+        buf.putInt(e.samples_per_chunk);
+        buf.putInt(e.sample_description_index);
     }
 
     @Override

common/src/main/java/com/frostwire/fmp4/TimeToSampleBox.java

@@ -24,7 +24,7 @@
  * @author gubatron
  * @author aldenml
  */
-public final class TimeToSampleBox extends FullBox {
+public final class TimeToSampleBox extends EntryBaseBox {
 
     protected int entry_count;
     protected Entry[] entries;
@@ -50,17 +50,26 @@ void read(InputChannel ch, ByteBuffer buf) throws IOException {
     }
 
     @Override
-    void write(OutputChannel ch, ByteBuffer buf) throws IOException {
-        super.write(ch, buf);
-
+    void writeFields(OutputChannel ch, ByteBuffer buf) throws IOException {
         buf.putInt(entry_count);
         IO.write(ch, 4, buf);
-        for (int i = 0; i < entry_count; i++) {
-            Entry e = entries[i];
-            buf.putInt(e.sample_count);
-            buf.putInt(e.sample_delta);
-            IO.write(ch, 8, buf);
-        }
+    }
+
+    @Override
+    int entryCount() {
+        return entry_count;
+    }
+
+    @Override
+    int entrySize() {
+        return 8;
+    }
+
+    @Override
+    void putEntry(int i, ByteBuffer buf) {
+        Entry e = entries[i];
+        buf.putInt(e.sample_count);
+        buf.putInt(e.sample_delta);
     }
 
     @Override