New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] - Library ESModule build #10

Closed

edvincandon wants to merge 1 commit into frouo:master from edvincandon:fix/build

Collaborator

edvincandon commented Mar 29, 2022

Typescript supports .js imports for .ts files. see why here : microsoft/TypeScript#16577 (comment)

Either that or :

use a bundler (IMO overkill for the size of next-markdown)
use a post-processor typescript plugin to append .js file extensions to relative imports after compilation


          fix: library es build

f34abf8

Owner

frouo commented Mar 29, 2022

Good to know: #8 (comment)

I've added a test but sadly it fails because the "github-slugger" module is undefined when the test is executed .. needed to mock it in order to create the test

do you maybe know why this is the case? did you have similar problems that node_module packages are undefined in tests?

frouo mentioned this pull request

implemented table of contents for each page #8

Merged

edvincandon closed this

frouo mentioned this pull request

Setup the project so it's easy to develop and test this nextjs library #6

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment