implemented table of contents for each page #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouo
reviewed
Mar 29, 2022
|
I've added a test but sadly it fails because the "github-slugger" module is undefined when the test is executed .. needed to mock it in order to create the test do you maybe know why this is the case? did you have similar problems that node_module packages are undefined in tests? |
|
That's absolutely awesome @dsumer, thank you 🎉 + tests wow 👏 Regarding your last comment, yes, we still have packaging issue, sorry about that. @edvincandon is working on it (cf. #10) and we will fix that in priority. |
|
☝🏻 rebased the branch on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.