Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that DMARC entries are generated as subdomain, Allow overwriting of DMARC and SPF subdomain records #1237

Merged
merged 4 commits into from Feb 9, 2024

Conversation

z-e-r-0-t
Copy link
Contributor

Description

Ensure that DMARC records are always generated as subdomain (see https://datatracker.ietf.org/doc/html/rfc7489#section-6.1).

Additionally ensure that manually specified SPF and DMARC records for subdomains can overwrite default records generated by Froxlor.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • Distribution: Gentoo
  • Nameserver: BIND

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@d00p d00p merged commit 686ca84 into froxlor:main Feb 9, 2024
9 checks passed
@z-e-r-0-t z-e-r-0-t deleted the dmarc branch February 9, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants