Prime generation #17
Merged
Prime generation #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er space and time performance; miscellaneous small improvements
|
Looks pretty good, just a couple minor nits already noted. I think you may want to get comfortable with rebasing...opening new branches to respond to review comments is going to get old fast. Feel free to shoot questions my way. |
|
Yup, in the process of fixing this up I made some great progress figuring |
(GENERATE-SMALL-PRIMES): don't need IRONCLAD package for symbols
glv2
added a commit
to glv2/ironclad
that referenced
this pull request
May 25, 2019
Make the PBKDF documentation consistent with the rest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the prime generation function and a performance improvement to MODULAR-INVERSE, and a small change to testfuns.lisp to not use keyword symbols.