Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for commercial property sizing attributes (RightmoveADF v1.3) #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

darrylfriend
Copy link

@darrylfriend darrylfriend commented Apr 5, 2017

RightMove ADF 1.3 specifies that commercial property sizing is its own object on the details object.
This PR adds a sizing group, which attaches to the details group.

Usage:

$request->property->details->sizing->minimum = 100;
$request->property->details->sizing->maximum = 200;
$request->property->details->sizing->area_unit = 2;

---- Below is the Rightmove spec for sizing ---

"sizing":{
     "type":"object",
     "id":"sizing",
     "required":false,
     "description":"The size details about the property being be sent",
     "properties": {
          "minimum":{
               "type":["number", "null"],
               "id":"minimum",
               "required":false,
               "minimum":0,
               "description":"The minimum size of the property being sent"
          },
          "maximum":{
               "type":["number", "null"],
               "id":"maximum",
               "required":false,
               "minimum":0,
               "description":"The maximum size of the property being sent"
          },
          "area_unit":{
               "type":["integer", "null"],
               "id":"area_unit",
               "required":false,
               "enum":[1, 2, 3, 4, null],
               "description":"Units which the property size is sent in: 1 sq ft 2 sq m 3 acre 4 hectares"
          }
     }
}```

"sizing":{
     "type":"object",
     "id":"sizing",
     "required":false,
     "description":"The size details about the property being be sent",
     "properties": {
          "minimum":{
               "type":["number", "null"],
               "id":"minimum",
               "required":false,
               "minimum":0,
               "description":"The minimum size of the property being
sent"
          },
          "maximum":{
               "type":["number", "null"],
               "id":"maximum",
               "required":false,
               "minimum":0,
               "description":"The maximum size of the property being
sent"
          },
          "area_unit":{
               "type":["integer", "null"],
               "id":"area_unit",
               "required":false,
               "enum":[1, 2, 3, 4, null],
               "description":"Units which the property size is sent in:
1 sq ft 2 sq m 3 acre 4 hectares"
          }
     }
}
@coveralls
Copy link

coveralls commented Apr 5, 2017

Coverage Status

Coverage remained the same at 0.0% when pulling 3e22b82 on darrylfriend:commercial-property-sizing into 28f9fdd on frozensheep:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants