Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PutAll should wait for the completion of all put operations #175

Open
shinnya opened this issue Jul 1, 2019 · 1 comment · May be fixed by #200
Open

PutAll should wait for the completion of all put operations #175

shinnya opened this issue Jul 1, 2019 · 1 comment · May be fixed by #200
Assignees
@koba-e964
Labels
High Priority This issue is important

Comments

@shinnya
Copy link
Contributor

shinnya commented Jul 1, 2019

In the following line,

frugalos/frugalos_segment/src/client/storage.rs

Line 316 in 1f2a549

if self.ok_count >= self.required_ok_count {

PutAll returns a result before all fragments is persisted. We should wait for the completion of all Futures to ensure the result of Futures.
@koba-e964
Copy link
Member

koba-e964 commented Jul 1, 2019 •
edited

Then probably using join_all will do the job.

@shinnya shinnya added the High Priority This issue is important label Dec 7, 2019
@koba-e964 koba-e964 linked a pull request Dec 12, 2019 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koba-e964 koba-e964

Labels
High Priority This issue is important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PutAll ensures all futures finish frugalos/frugalos
2 participants
@shinnya @koba-e964