PutAll ensures all futures finish #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koba-e964
changed the title
koba-e964
force-pushed
the
feature/wait-for-puts-completion
branch
from
ca512bf
to
bc0b908
Compare
koba-e964
commented
Aug 27, 2019
| Err(_) => unreachable!(), | ||
| } | ||
| thread::sleep(Duration::from_millis(1)); | ||
| }; |
There was a problem hiding this comment.
TODO: Needs comments to justify waiting time of 1ms, or possibly a better alternative.
There was a problem hiding this comment.
src/daemon.rs の spawner をここまで持ってきて、spawner.spawn で Future を実行する方法もある。
There was a problem hiding this comment.
待つ時間は長くてもそこまで問題にはならなそうで、spawner を持ってくるのは変更が大きそうという理由から、待つ時間を環境変数で設定できるようにします (デフォルトを 100ms くらいにします)
根拠:
- 待つ時間は長くても問題にならない: このコードだと PUT アクセス1個につき1個のスレッドが立つ。このスレッドは PUT が全部終わるのを待って終了するため、PUT アクセスにかかる時間程度までなら待ち時間によらずかかる時間はほぼ一定であるため。
- spawner を持ってくるのは変更が大きそう: Bucket -> Client -> StorageClient -> DispersedClient -> PutAll と順に変更する必要があるため。
- 100ms: 根拠に乏しいが PUT より充分短い時間であるため。
There was a problem hiding this comment.
この実装だと、tasque_task_duration_seconds というメトリクスの quantile クエリがほぼ残りの PUT 由来となります。問題かどうかはよくわかりません。
koba-e964
force-pushed
the
feature/wait-for-puts-completion
branch
from
840ca5e
to
52f72b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Please check one of the following:
Description of changes
frugalos_segment::client::PutAllが、与えられた future を全て確実に実行するようになる。Behavior
frugalos_segment::client::PutAllが required_ok_count 個の future を成功裡に実行した後、残りの future を捨てる代わりに DefaultCpuTaskQueue に投げるようになる。Purpose
Fixes #175.
PUT リクエストで保存すべきフラグメントが全部保存されない可能性があるという問題があり、今回の変更はそれを部分的に解決する。
この変更により、クライアントに応答を返した後も内部では Put リクエストを実行し続け、仮に失敗した時には
PutAllMetricsのlost_fragments_totalにカウントされる。今後これに依存する形で以下のような PR を投げる予定。
Checklists
cargo fmt --all.